Add cnotes - #117
Merged
jeremiah-kang merged 6 commits intoJul 23, 2026
Merged
Conversation
jeremiah-kang
commented
Jul 20, 2026
jeremiah-kang
commented
Collaborator
- Updated native.py and hecdss.py to support updates to C api (hecdss.h and hecdss.c)
- Added support for cnotes text columns within RegularTimeSeries and IrregularTimeSeries
- Added support for reading and writing cnotes text columns to and from CSV
Collaborator
Author
|
I just realized these tests are failing because the C library that I updated hasn't taken effect here yet. |
ktarbet
approved these changes
Jul 23, 2026
jeremiah-kang
marked this pull request as ready for review
July 23, 2026 18:32
jeremiah-kang
merged commit Jul 23, 2026
a4a9ad9
into
HydrologicEngineeringCenter:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.